boranseckin/bridge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Server init message does not show correct names if there is only one specified channel #6

New issue
Closed
opened 2020-03-25 21:55:54 -04:00 by boranseckin · 1 comment
boranseckin commented 2020-03-25 21:55:54 -04:00 (Migrated from github.com)
Copy link

Description
When the server is initialized, the message does not show correct channel names if there is only one additional channel specified by the command line argument. The specified channel, however, correctly initializes.

To Reproduce
Steps to reproduce the behaviour:

  1. Start the server by the command bridge-server -c test
  2. See the message printing: Bridge - Server initialized! Port: 3636 - Channel: [/]

Expected behaviour
When there is no additional channel, the channel array includes undefined and its length is one. When there is only one additional channel, the channel array includes that that channel and its length is one. Since both situations have the same output, [line 63 at server.js](boranseckin/bridge@207a73ece3/serve r.js#L63) prints the same result.

Version: 1.3.1

**Description** When the server is initialized, the message does not show correct channel names if there is only one additional channel specified by the command line argument. The specified channel, however, correctly initializes. **To Reproduce** Steps to reproduce the behaviour: 1. Start the server by the command `bridge-server -c test` 2. See the message printing: `Bridge - Server initialized! Port: 3636 - Channel: [/]` **Expected behaviour** When there is no additional channel, the channel array includes `undefined` and its length is one. When there is only one additional channel, the channel array includes that that channel and its length is one. Since both situations have the same output, [line 63 at server.js](https://github.com/boranseckin/bridge/blob/207a73ece329d15fff8299792dc10c38345484a0/serve r.js#L63) prints the same result. **Version: 1.3.1**
boranseckin commented 2020-03-25 22:06:39 -04:00 (Migrated from github.com)
Copy link

Fixed with b490d73344.

Fixed with b490d73344c187f4c09220dd7106a0a7ca964a05.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/npm_and_yarn/multi-82ad408bf4
dependabot/npm_and_yarn/socket.io-parser-3.3.4
v1.3.8
v1.3.7
v1.3.6
v1.3.5
v1.3.4
v1.3.3
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
boranseckin/bridge#6
No description provided.